fix: return false on uncomparable filter instead of panic

Signed-off-by: Jeff Davis <[email protected]>
vmware-labs · Jun 15, 2021 · ed4ed3e · ed4ed3e
1 parent 637b8b6
commit ed4ed3e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/yamlpath/filter.go b/pkg/yamlpath/filter.go
@@ -290,7 +290,7 @@ func matchRegularExpression(parseTree *filterNode) filter {
 
 func stringMatchesRegularExpression(s, expr typedValue) bool {
 	if s.typ != stringValueType || expr.typ != regularExpressionValueType {
-		panic("unexpected types") // should never happen
+		return false // can't compare types so return false
 	}
 	re, _ := regexp.Compile(expr.val) // regex already compiled during lexing
 	return re.Match([]byte(s.val))