This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Migrate to cds-icon
#543
Open
Migrate to cds-icon
#543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ttsvetko, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
ttsvetko
commented
Dec 4, 2023
Introduce a new `IconsModule` that register the `cds-icon` component using the provided by Clarity `CdsIconModule` and import all Clarity icons. Testing Done: Run e2e tests. Signed-off-by: Tsvetan Emilov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
clr-icontocds-iconcomponentWhat does this change do?
Introduce a new
IconsModulethat register thecds-iconcomponent using the provided by ClarityCdsIconModuleand import all Clarity icons.What manual testing did you do?
Ensure that all components using cds-icon are working as expected - icon is visible.
Screenshots (if applicable)
Does this PR introduce a breaking change?
Other information