Improve UI and add command line instructions #137
Conversation
- Serve CSS/JS files localy. Resolves vmware-archive#102 - Copy to clipboard button is placed more prominently - Places install instructions below the config instruction - Add command line instructions for users running on Windows. Resolves vmware-archive#102 Signed-off-by: Joshua Brunner <[email protected]>
Since Dockerfile does not `make setup`, copy assets manually. Also fix serving assets by esc instead from filesystem. Signed-off-by: Joshua Brunner <[email protected]>
|
It would be huge for us to get Windows instructions incorporated with gangway. Is there any help needed to move this forward / test? /cc @alexbrand @idealhack |
|
I tested BASH & POWERSHELL, all works as expected. Thanks @jbrunner |
|
Thanks for this @jbrunner! I'd like to smoke test this on my cluster to see how things look. |
|
@stevesloka Did you had any issues? Can i help you? |
|
@jbrunner could you please fix the conflicting files? I love this improvement since lots of cluster is not accessible to the outside network, so the JS/CSS resource can't be loaded. Also, it benefits the Windows users 💯 . |
Signed-off-by: Joshua Brunner <[email protected]>
|
@jenting now we have to wait six months again? ;) |
ping @stevesloka, PTAL 🙇 |
There was a problem hiding this comment.
/lgtm Just need to get the DCO happy with the sign-off @jbrunner. Could you verify your commits are all signed?
|
@jbrunner If you have time, could you please take a look to make DCO happy? Thanks in advance. |
Signed-off-by: Joshua Brunner [email protected]