-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoconf build system for bundled C sources #35
Conversation
@vmchale is the symbol clash resolved in the new libarchive version? In that case we may not need this. But it's an alternative approach that may be more resilient, but incurs additional maintenance cost. |
configure.ac
Outdated
@@ -0,0 +1,383 @@ | |||
m4_define([LIBARCHIVE_VERSION_S],[3.7.2]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is a partial rip-off of the upstream configure.ac... so it might diverge in the future (just like config.h).
We could also split out into two packages similar to: |
4529725
to
7cb9c16
Compare
It seems splitting packages is actually problematic, because |
It actually works with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thanks!
Maybe mention the autoreconf -fi
step in a README.md
somewhere? I had to look at the CI script to figure out how to run/test locally.
Done |
Nothing left here I think |
@vmchale this is good to go |
Ah sorry! I hope you were able to merge at least? I've added you on Hackage as well! Thanks again! |
Fixes #33