Store world save variables at characters db

[schell244]

🍰 Pullrequest

Store world save variables at characters db, as they are related to player actions and make world database read only.
This will allow to apply a fresh world db without wiping any saved states.
Also removed LoadVariable function, as it was unused.
(Changes have been tested on raspywow server)

How2Test

• Apply changes from this PR
• Start server and check save states are now stored at world_persistent_variables at characters db
• Do changes to world states (for example start Stranglethorn Vale Fishing and hand in 40 tasy fish)
• Apply fresh world db, reboot server -> event is still completed for this week

Todo / Checklist

• None

[ratkosrb]

World states is already a term that exists, and it's something that's sent to client. We should not have confusing naming like this, because it implies that those are the same world states blizzard sends if you name the table like this, and that is not what it contains. Variables is our own custom indexes and values, not using blizzard's ids for stuff.

[0blu]

variables is too generic, especially in a database like characters.
Maybe something like this:

• persistent_world_data
• persistent_state
• world_persistence
• world_progress
• game_state
• realm_state

or another permutation of these words?

[schell244]

maybe world_persistent_variables?

[shudza]

... and make world database read only.

game_events is written to as well, or am I wrong?

[schell244]

... and make world database read only.

game_events is written to as well, or am I wrong?

Oh yes, you're right, there are querys on game_event_creature and game_event_creature_data. Would probably make sense to move those tables to charcter db as well at some point.

[shudza]

I don't think it makes sense to change only variables then. For example, variables stores stuff like resources for war effort, but the stage it self is stored in game_events. So if the point was to make world db ephemeral/read-only, this would probably cause issues.