Fix to sylvanas getting stuck in idle motion and not evading outside throne room

[balakethelock]

🍰 Pullrequest

• Sylvanas evade check was completely meaningless checking for distance between her and her position, changed to height based check (Her throne room is slightly lower than the hallway leading to it)

• fixed being set to idle motion after fade

Proof

• None

Issues

• None

How2Test

• .tele undercity
• pull sylvanas outside of room, correctly resets

Todo / Checklist

• None

[Daribon]

Should Sylvanas and Varimathras even evade if pulled outside the room?
It was added in this commit back in 2017: a15ff59
Video from 2008 shows Varitmathras being tanked in the tunnel: https://youtu.be/UTkrm1zSmcE?si=nUE4eu-i73om_rzG&t=359
Video from 2008 shows Varitmathras killing people halfway up the tunnel: https://youtu.be/tgUiuGz4vYQ?si=G1l029mkDzMrFbHk&t=186
Video from 2006 shows Varitmathras being tanked in the tunnel: https://youtu.be/ZycHpmcFLHU?si=4PzHrDo3WXnFQtqx&t=427

Image from 2006 showing both Sylvanas and Varitmathras in the tunnel:
https://vanilla-archive.thealphaproject.eu/media/Vanilla-Screenshot-Archive/Cities/Undercity/WoWScrnShot_010806_185650.jpg

[balakethelock]

Good finds. I guess the big question in this is, do faction leaders have a reset distance in general? They all seem to be located in a sort of throne room with clearly defined boundaries so I guess people just assumed they are leashed to that throne room.

[ratkosrb]

varimathas.mp4

I pulled them on classic, but Sylvanas turned invisible and I lost her as target. Varimathas went into the tunnel though.

[Daribon]

varimathas.mp4

I pulled them on classic, but Sylvanas turned invisible and I lost her as target. Varimathas went into the tunnel though.

Yes, she appears to cast an invis spell with this icon https://www.wowhead.com/classic/spells?filter=15;0;spell_magic_lesserinvisibilty
Old allakhazam/thottbot comments mention her teleporting around, which is probably just the invis looking like teleport.

The current sylvanas script uses this spell for invis: https://www.wowhead.com/classic/spell=20672/fade which has a different icon.