Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability that is unused in classic from Skeram script #2150

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

balakethelock
Copy link
Contributor

@balakethelock balakethelock commented Aug 4, 2023

🍰 Pullrequest

True fulfillment has an added spell that makes the player immune to stuns, roots and snares. In classic this is an unused spell, not applied with the mind control, so removing it from here to match that.

Proof

https://youtu.be/tZpkoxwS6ns?t=335
timestamp 5:35
look at the druid that gets mind controlled. He is affected by paladin stun and frost nova proving that Skeram didn't make him immune to either mechanic.
It doesn't exist in wowhead https://www.wowhead.com/classic/spell=26526
while the other ones exist

Issues

  • None

How2Test

  • .go creature 87571
  • kill trash leading to skeram
  • spawn many partybots
  • .learn 10230 for frostnova
  • .learn 10308 for hammer of justice
  • engage the boss, wait for it to use True Fulfillment
  • use the abilities on the mind controlled partybot

image

Todo / Checklist

  • none

True fulfillment has an added spell that makes the player immune to stuns, roots and snares. In classic this spell is not applied to with the mind control, so removing it from here to match it.
@balakethelock balakethelock marked this pull request as ready for review August 4, 2023 21:02
@ratkosrb
Copy link
Contributor

ratkosrb commented Jan 7, 2024

Is it possible that the spell was removed in a later patch that nerfed it?

@0blu 0blu added the CPP A issue / PR which references CPP code label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPP A issue / PR which references CPP code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants