Spell groups and aura exclusivity

[balakethelock]

🍰 Pullrequest

• Cleaned up spell groups table. 80% of the groups were duplicates, non-functional, or redundant from IsNoStackSpellDueToSpell.
• Rewrote wotlk code to something that makes much more sense for vanilla. Removed some exclusivity rules that had no logical reason to be there in the first place.

Proof

• Spreadsheet documenting the new db tables in easy to read format here

Issues

• fixes 🐞 [Bug] Spell Group 1022 contains wrong spell #1884

How2Test

• None

Todo / Checklist

• None

[TuriansNotBad]

Rejuvenation - rank 1 doesn't override rank 2 but no longer displays "A more powerful spell is active" message like it would without this commit. Same for Renew.

I understand that vmangos spell bouncing is incomplete and its probably necessary to edit it this way. On classic a higher potency rejuvenation will give "A more powerful spell is active" if a player with inferior +healing tried to cast it for example.

Just a minor thing from my testing.

[balakethelock]

Rejuvenation - rank 1 doesn't override rank 2 but no longer displays "A more powerful spell is active" message like it would without this commit. Same for Renew.

I understand that vmangos spell bouncing is incomplete and its probably necessary to edit it this way. On classic a higher potency rejuvenation will give "A more powerful spell is active" if a player with inferior +healing tried to cast it for example.

Just a minor thing from my testing.

In classic is t based on rank or power? Will a rank 5 rejuvenation from a druid with 1000 healing power overwrite a rank 6 rejuvenation from a druid with 0 healing power or will it say "A more powerful spell is active"

[Wall-core]

I haven't checked your commit but last time I went through spell groups, there were a few hidden gems like rank 3 int scroll stacking with mage buff which I assume was done on purpose to give someone unfair advantage. Not sure if you combed through the whole thing or just same-chain ranks

[balakethelock]

I haven't checked your commit but last time I went through spell groups, there were a few hidden gems like rank 3 int scroll stacking with mage buff which I assume was done on purpose to give someone unfair advantage. Not sure if you combed through the whole thing or just same-chain ranks

I have tried to comb through everything and not miss even the obscure int buff from a quest in the barrens.
The hidden gems in the old spell groups table is in most cases somebody accidentally putting the item id of a scroll or elixir instead of the spell id

[ShiyoKozuki]

You can have multiple ranks of battleshout after getting this PR, this isn't correct.

[ShiyoKozuki]

Please correct me if I'm wrong but for me, this is no longer compatible with the server and causes errors if you run the migration.
Can this PR be fixed or removed if so?