Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify release-on-merge with publish-npm style #26

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

devin-ai-integration[bot]
Copy link

Updates release-on-merge.yml to use the same publish-npm script as publish-npm.yml workflow for consistency.

Changes:

  • Replace direct npm publish with publish-npm script
  • Update environment variable name to match publish-npm.yml
  • Keep existing version check logic intact

Link to Devin run: https://app.devin.ai/sessions/ed06ed23771e4f3d9fa9223f1aa60cbc

Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot force-pushed the devin/1736428803-workflow-update branch from 9014fac to 9e0ef63 Compare January 9, 2025 13:27
devin-ai-integration bot and others added 4 commits January 9, 2025 13:28
The release-doctor workflow only validated NPM_TOKEN, which is now handled
by the npm publish step in release-on-merge.yml. This commit disables the
workflow and adds deprecation notices.

Part of PR #26

Co-Authored-By: [email protected] <[email protected]>
Remove the deprecated workflow file as its functionality is now entirely
handled by release-on-merge.yml.

Part of PR #26

Co-Authored-By: [email protected] <[email protected]>
@shahrear33 shahrear33 merged commit 360cac1 into main Jan 9, 2025
3 checks passed
stainless-app bot pushed a commit that referenced this pull request Jan 9, 2025
The release-doctor workflow only validated NPM_TOKEN, which is now handled
by the npm publish step in release-on-merge.yml. This commit disables the
workflow and adds deprecation notices.

Part of PR #26

Co-Authored-By: [email protected] <[email protected]>
stainless-app bot pushed a commit that referenced this pull request Jan 9, 2025
Remove the deprecated workflow file as its functionality is now entirely
handled by release-on-merge.yml.

Part of PR #26

Co-Authored-By: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant