Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Benchmark] Unset best_of when running v1 benchmark #14303

Closed
wants to merge 5 commits into from
Closed

[Benchmark] Unset best_of when running v1 benchmark #14303

wants to merge 5 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Mar 5, 2025 •
edited by github-actions bot
Loading

The check is introduced by #14159 and it will fail the benchmark serving script on V1 with VLLM V1 does not yet support best_of error as the parameter is not yet supported. All the serving metrics fail to show up on v1 dashboard after #14159 lands.

Testing

ENGINE_VERSION=v1 HF_TOKEN=<REDACTED> bash .buildkite/nightly-benchmarks/scripts/run-performance-benchmarks.sh works locally again

cc @robertgshaw2-redhat @houseroad @ywang96 @WoosukKwon

huydhn added 5 commits March 5, 2025 10:42
@huydhn
[Benchmark] Unset best_of when running v1 benchmark
3c78e5d 
The check is introduced by vllm-project#14159
and it will fail v1 benchmark with `VLLM V1 does not yet support
best_of` error as the parameter is not yet supported

Signed-off-by: Huy Do <[email protected]>
@huydhn
Fix lint
39ba163 
Signed-off-by: Huy Do <[email protected]>
@huydhn
Use append
4da9ebc 
Signed-off-by: Huy Do <[email protected]>
@huydhn
Use the simpler approach
2683e6f 
Signed-off-by: Huy Do <[email protected]>
@huydhn
It's working now
c900571 
Signed-off-by: Huy Do <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin
Copy link
Member

mgoin commented Mar 5, 2025

We are planning to remove best_of entirely here #13997

@huydhn
Copy link
Contributor Author

huydhn commented Mar 5, 2025 •
edited
Loading

We are planning to remove best_of entirely here #13997

Oh, got it, I'll wait for #13997 to land then.

@huydhn huydhn closed this Mar 5, 2025
@huydhn huydhn mentioned this pull request Mar 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huydhn @mgoin