Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] typo find in deepseek_v2 #14106

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

noooop
Copy link
Contributor

@noooop noooop commented Mar 3, 2025

set routed_scaling_factor twice

Copy link

github-actions bot commented Mar 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 3, 2025
@noooop
Copy link
Contributor Author

noooop commented Mar 3, 2025

requests.exceptions.ReadTimeout: (ReadTimeoutError("HTTPSConnectionPool(host='huggingface.co', port=443): Read timed out.

I use model_overwrite to redirect the model name to a local folder

while keeping the model name in the test file without being hardcoded.

def model_overwrite(model):
    import pathlib

    model_overwrite_name = ".model.overwrite"
    model_overwrite_path = pathlib.Path.home() / model_overwrite_name
    model_overwrite_dict = {}

    if model_overwrite_path.exists():
        for line in open(model_overwrite_path).readlines():
            model_name, overwrite_name = line.split("\t")
            model_overwrite_dict[model_name] = overwrite_name.strip()

    if model in model_overwrite_dict:
        new_model = model_overwrite_dict[model]
        logger.info(f"model overwrite: [{model}] -> [{new_model}]")
        model = new_model

    return model

@youkaichao

It is better to change CI/CD to use local model testing

draft

Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I've retried all the failed CI jobs so hopefully they'll all go through.

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, looks straightforward enough to force-merge.

@youkaichao youkaichao merged commit e584b85 into vllm-project:main Mar 3, 2025
45 of 51 checks passed
johnnynunez pushed a commit to johnnynunez/vllm that referenced this pull request Mar 3, 2025
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants