-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Adding script to setup ray for multi-node vllm deployments #12913
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Edwinhr716 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This is not LWS specific, it is useful for any multi-node vllm deployment |
@@ -0,0 +1,94 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to name the file multi-node-serving.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please show an example? I want to make sure we support setting any vllm backend flag
it would be very similar to how we currently do it in the LWS repo:
|
Signed-off-by: Edwinhr716 <[email protected]>
ray_port=6379 | ||
ray_init_timeout=300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can those be changed a env vars?
@robertgshaw2-redhat do you have a minute to look into this one? It will allow us to easily launch multi-node inference workloads, see examples at https://github.com/kubernetes-sigs/lws/tree/main/docs/examples/vllm |
Right now we have to-rebuild the container to include this script, but it would be great to have it embedded in the main vllm container. |
FIX #8302 (link existing issues this PR will resolve)