Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hardware][Gaudi][BugFix] Fix dataclass error due to triton package update #12338

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

zhenwei-intel
Copy link
Contributor

@zhenwei-intel zhenwei-intel commented Jan 23, 2025

Fix dataclass error caused by Triton package update by pinning Triton to v3.1.0 as a temporary workaround..

Error logs:

  File "/usr/local/lib/python3.10/dist-packages/habana_frameworks/torch/core/__init__.py", line 100, in wrapper
    ret = original_fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/_inductor/debug.py", line 26, in <module>
    from . import config, ir  # noqa: F811, this is needed
  File "/usr/local/lib/python3.10/dist-packages/habana_frameworks/torch/core/__init__.py", line 100, in wrapper
    ret = original_fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/_inductor/ir.py", line 77, in <module>
    from .runtime.hints import ReductionHint
  File "/usr/local/lib/python3.10/dist-packages/habana_frameworks/torch/core/__init__.py", line 100, in wrapper
    ret = original_fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/_inductor/runtime/hints.py", line 36, in <module>
    attr_desc_fields = {f.name for f in fields(AttrsDescriptor)}
  File "/usr/lib/python3.10/dataclasses.py", line 1198, in fields                                                                                                                           raise TypeError('must be called with a dataclass type or instance') from None
TypeError: must be called with a dataclass type or instance

cherry-pick from vllm-fork:
HabanaAI#729

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jan 23, 2025
@zhenwei-intel zhenwei-intel marked this pull request as ready for review January 23, 2025 05:53
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fixing, let's check if the HPU tests on CI can pass

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 23, 2025
@jeejeelee jeejeelee enabled auto-merge (squash) January 23, 2025 06:40
@jeejeelee jeejeelee merged commit 8ae5ff2 into vllm-project:main Jan 23, 2025
88 checks passed
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
tjtanaa pushed a commit to EmbeddedLLM/vllm that referenced this pull request Jan 27, 2025
tjtanaa pushed a commit to EmbeddedLLM/vllm that referenced this pull request Jan 27, 2025
tjtanaa pushed a commit to EmbeddedLLM/vllm that referenced this pull request Jan 28, 2025
rasmith pushed a commit to rasmith/vllm that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants