-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mypy type checking for vllm/worker #11418
mypy type checking for vllm/worker #11418
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: lucast2021 <[email protected]>
f8598b7
to
4635a54
Compare
Please fix the mypy errors. |
Signed-off-by: lucast2021 <[email protected]>
yapf is still failing. |
Signed-off-by: lucast2021 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this!
Signed-off-by: lucast2021 <[email protected]> Co-authored-by: lucast2021 <[email protected]>
Signed-off-by: lucast2021 <[email protected]> Co-authored-by: lucast2021 <[email protected]>
Signed-off-by: lucast2021 <[email protected]> Co-authored-by: lucast2021 <[email protected]>
Signed-off-by: lucast2021 <[email protected]> Co-authored-by: lucast2021 <[email protected]>
Signed-off-by: lucast2021 <[email protected]> Co-authored-by: lucast2021 <[email protected]> Signed-off-by: Bowen Wang <[email protected]>
Signed-off-by: lucast2021 <[email protected]> Co-authored-by: lucast2021 <[email protected]>
A few mypy type hints for vllm/worker
#3680