Skip to content

[core][distributed] use tcp store directly #10275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

youkaichao
Copy link
Member

inspired by pytorch/rfcs#71 (comment) , we can use https://pytorch.org/docs/stable/distributed.html#torch.distributed.TCPStore directly, instead of depending on internal APIs like rendezvous and prefix store.

Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
Copy link
Member Author

youkaichao commented Nov 12, 2024

running stress tests locally to see if it will hang or have race conditions

@youkaichao
Copy link
Member Author

locally tested 100 times and it's good.

@youkaichao youkaichao merged commit 0d4ea3f into vllm-project:main Nov 13, 2024
22 of 24 checks passed
@youkaichao youkaichao deleted the improve_init branch November 13, 2024 01:36
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant