Skip to content

Commit

Permalink
[V1][Minor] Remove obsolete FIXME comment (#14304)
Browse files Browse the repository at this point in the history
Signed-off-by: Nick Hill <[email protected]>
  • Loading branch information
njhill authored Mar 5, 2025
1 parent ca2ca8d commit a32c866
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions vllm/v1/worker/gpu_input_batch.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,6 @@ def add_request(
if sampling_params.logit_bias is not None:
self.logit_bias[req_index] = sampling_params.logit_bias

# FIXME: this implementation is incorrect. We create this mask
# then apply -inf to these specific tokens, which means we never
# select the allowed tokens! We cannot do the reverse, since
# this will impact the requests that do not have allowed_token_ids.
# This feature is currently disabled on V1 (we reject in Processor).
if sampling_params.allowed_token_ids:
self.has_allowed_token_ids.add(req_id)
if self.allowed_token_ids_mask_cpu_tensor is None:
Expand Down

0 comments on commit a32c866

Please sign in to comment.