Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Training] Datasets - update Module #1209

Merged
merged 9 commits into from
Mar 5, 2025
Merged

[Training] Datasets - update Module #1209

merged 9 commits into from
Mar 5, 2025

Conversation

horheynm
Copy link
Collaborator

@horheynm horheynm commented Feb 27, 2025 •
edited
Loading

Order of reviews:
#1206
#1207
#1209 <-- Here
#1212
#1214

SUMMARY:

  • Move dataset logic out of transformers module src/llmcompressor/transformers/finetune/data/data_helpers.py, add it to src/llmcompressor/datasets/utils.py

TEST PLAN:
Pass tests

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@horheynm horheynm changed the title Datasets [Training] Datasets - update Module Feb 28, 2025
@horheynm horheynm added the ready When a PR is ready for review label Feb 28, 2025
This was referenced Feb 28, 2025
Open
Merged
Merged
Merged
@horheynm
pass
72376e7 
Signed-off-by: George Ohashi <[email protected]>
@horheynm horheynm removed the ready When a PR is ready for review label Mar 3, 2025
dsikka pushed a commit that referenced this pull request Mar 3, 2025
@horheynm
[Training] Decouple Argument parser (#1207)
7bb517f 
Order of reviews:
#1206
#1207 <-- Here
#1209 
#1212
#1214 

SUMMARY:
* Decouple arg parser to be used for both oneshot and train

TEST PLAN:
* Pass tests
dsikka added a commit that referenced this pull request Mar 5, 2025
@horheynm @dsikka
[Cosmetic] Rename data_args to dataset_args (#1206)
391b202 
Order of reviews:
#1206  <-- Here
#1207
#1209 
#1212
#1214 

SUMMARY:
Rename data_args to dataset_args

TEST PLAN:
Pass tests
FInd `data_args` using `grep`

---------

Signed-off-by: George Ohashi <[email protected]>
Co-authored-by: Dipika Sikka <[email protected]>
@horheynm horheynm added the ready When a PR is ready for review label Mar 5, 2025
brian-dellabetta
brian-dellabetta previously approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! one nit suggestion

@dsikka dsikka enabled auto-merge (squash) March 5, 2025 17:09
@dsikka dsikka merged commit 8fc6012 into main Mar 5, 2025
16 of 17 checks passed
@dsikka dsikka deleted the datasets branch March 5, 2025 18:36
dsikka pushed a commit that referenced this pull request Mar 6, 2025
@horheynm
[Training] Unifying Preprocess + Postprocessing logic for Train/Onesh…
9d82f35 
…ot (#1212)

Order of reviews:
#1206
#1207
#1209
#1212  <-- Here
#1214

SUMMARY:
* Move the preprocessing and postprocessing logic out of
`src/llmcompressor/transformers/finetune/text_generation.py` and into
`src/llmcompressor/entrypoints/utils.py`

TEST PLAN:
Pass tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@dsikka dsikka dsikka approved these changes

Assignees
No one assigned
Labels
ready When a PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@horheynm @brian-dellabetta @dsikka