Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Callbacks] Remove EventLifecycle and on_start event #1170

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
9b3e216
remove pre_initialize_structure
kylesayrs Feb 17, 2025
a68bc1e
WIP
kylesayrs Feb 17, 2025
3bff7d1
remove preinit event
kylesayrs Feb 17, 2025
14e47a5
remove order test
kylesayrs Feb 17, 2025
c6a9e6b
Merge branch 'main' into kylesayrs/remove-preinitialize-structure
kylesayrs Feb 17, 2025
6b882bb
consolodate saving
kylesayrs Feb 18, 2025
bb35a74
typos
kylesayrs Feb 18, 2025
71903ff
add todos
kylesayrs Feb 18, 2025
d39d375
dreggs, style
kylesayrs Feb 18, 2025
7cc5a6d
typo
kylesayrs Feb 18, 2025
9865fa3
adjust typehint
kylesayrs Feb 18, 2025
68ce624
allow prepending
kylesayrs Feb 18, 2025
5b7cc03
check saved recipe contents
kylesayrs Feb 18, 2025
bdc4fa5
consolidate saving paths
kylesayrs Feb 18, 2025
a83b0aa
remove broken import
kylesayrs Feb 18, 2025
4efd116
Merge remote-tracking branch 'origin' into kylesayrs/consolidate-saving
kylesayrs Feb 18, 2025
b9f0bd1
add back def
kylesayrs Feb 18, 2025
29ab794
Merge remote-tracking branch 'origin' into kylesayrs/remove-preinitia…
kylesayrs Feb 18, 2025
0a2642b
save state
kylesayrs Feb 18, 2025
0c70881
Merge branch 'kylesayrs/consolidate-saving' into kylesayrs/remove-pre…
kylesayrs Feb 18, 2025
60371ef
remove verbose messages
kylesayrs Feb 18, 2025
bf9a8cd
fix double initialization
kylesayrs Feb 18, 2025
e16836b
merge, add todos
kylesayrs Feb 19, 2025
3d64d57
rename function
kylesayrs Feb 25, 2025
55984c4
remove accidentally added files
kylesayrs Feb 25, 2025
05fa5f6
Merge remote-tracking branch 'origin' into kylesayrs/remove-preinitia…
kylesayrs Feb 25, 2025
53d762e
Merge remote-tracking branch 'origin' into kylesayrs/remove-preinitia…
kylesayrs Feb 25, 2025
e026658
add debug statement
kylesayrs Feb 25, 2025
b32c92f
remove relevant tests and imports
kylesayrs Feb 25, 2025
0ffef7a
solidify modifier lifecycle
kylesayrs Feb 25, 2025
8e47612
adjust errors
kylesayrs Feb 25, 2025
40f0b0c
add comment
kylesayrs Feb 25, 2025
0cf39cb
remove last_event
kylesayrs Feb 25, 2025
71494c3
Merge branch 'kylesayrs/remove-preinitialize-structure' into kylesayr…
kylesayrs Feb 25, 2025
09fdee4
remove check_initialized
kylesayrs Feb 25, 2025
17768c0
add event to tests
kylesayrs Feb 26, 2025
21271e3
save changes for later
kylesayrs Feb 26, 2025
b734bd6
save more changes for later
kylesayrs Feb 26, 2025
9f87809
remove todos
kylesayrs Feb 26, 2025
f595d92
Merge remote-tracking branch 'origin' into kylesayrs/remove-start_event
kylesayrs Feb 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/llmcompressor/core/__init__.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
from llmcompressor.core.events import (
CallbacksEventLifecycle,
Event,
EventLifecycle,
EventType,
OptimizerEventLifecycle,
)
from llmcompressor.core.events import Event, EventType
from llmcompressor.core.lifecycle import CompressionLifecycle
from llmcompressor.core.model_layer import ModelParameterizedLayer
from llmcompressor.core.session import CompressionSession
Expand All @@ -22,9 +16,6 @@
__all__ = [
"Event",
"EventType",
"EventLifecycle",
"CallbacksEventLifecycle",
"OptimizerEventLifecycle",
"State",
"Data",
"Hardware",
Expand Down
11 changes: 1 addition & 10 deletions src/llmcompressor/core/events/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,5 @@
"""

from .event import Event, EventType
from .event_lifecycle import EventLifecycle
from .lifecycle_callbacks import CallbacksEventLifecycle
from .lifecycle_optimizer import OptimizerEventLifecycle

__all__ = [
"Event",
"EventType",
"EventLifecycle",
"CallbacksEventLifecycle",
"OptimizerEventLifecycle",
]
__all__ = ["Event", "EventType"]
171 changes: 0 additions & 171 deletions src/llmcompressor/core/events/event_lifecycle.py

This file was deleted.

Loading