Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Test Failures #1

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Address Test Failures #1

merged 6 commits into from
Jun 24, 2024

Conversation

Satrat
Copy link
Contributor

@Satrat Satrat commented Jun 24, 2024

Fixing a few errors that were carried over from the old repo:

  • defaults in State needed to be initialized with a default_factory for python 3.11 compatability
  • missing dependencies: sparsezoo (will remove in a follow-up PR)
  • remove un-needed dependencies: evaluate, safetensors, sentencepiece
  • fixing a malformed recipe in the quantization tests
  • removing the mypy quality check for now, it was a new addition and there are many style failures. I think its best to address all of them once the repo is in a more stable state

@Satrat Satrat changed the title [WIP] Address Test Failures Address Test Failures Jun 24, 2024
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable sweep to me. We should also fix the link issues, seems to mostly be missing files or neuralmagic links

@Satrat Satrat merged commit e8c07af into main Jun 24, 2024
7 of 12 checks passed
@Satrat Satrat deleted the sa/test_failures branch June 24, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants