Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make schemas in status draft editable #61

Closed
wants to merge 6 commits into from
Closed

Make schemas in status draft editable #61

wants to merge 6 commits into from

Conversation

wwerner
Copy link
Contributor

@wwerner wwerner commented Oct 20, 2019 •
edited
Loading

Uses monaco editor in the schema view (drafts only) and PATCHes the specification.

Open issues:

image

Closes #57

VaughnVernon
VaughnVernon approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@VaughnVernon VaughnVernon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwerner Thanks! Please merge when ready.

@wwerner
Copy link
Contributor Author

wwerner commented Oct 28, 2019

Closed in favor of #67, which also contains the commits for updating schema from this branch.

@wwerner wwerner closed this Oct 28, 2019
@wwerner wwerner deleted the feature/57-edit_draft_schemas branch December 6, 2019 20:50
@wwerner wwerner self-assigned this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaughnVernon VaughnVernon VaughnVernon approved these changes

Assignees

@wwerner wwerner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Editing Fails On Existing Draft SchemaVersion
2 participants
@wwerner @VaughnVernon