Skip to content
This repository has been archived by the owner on Feb 19, 2023. It is now read-only.

Commit

Permalink
Fix some missing Initialize hints (#53566)
Browse files Browse the repository at this point in the history
* Fix some missing initialize hints

* Whitelist /mob/dview not calling /atom/Initialize()

* Better idea
  • Loading branch information
SpaceManiac authored Sep 13, 2020
1 parent 7e62ebb commit 899a9e0
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions code/__HELPERS/unsorted.dm
Original file line number Diff line number Diff line change
Expand Up @@ -1178,6 +1178,9 @@ GLOBAL_DATUM_INIT(dview_mob, /mob/dview, new)

/mob/dview/Initialize() //Properly prevents this mob from gaining huds or joining any global lists
SHOULD_CALL_PARENT(FALSE)
if(flags_1 & INITIALIZED_1)
stack_trace("Warning: [src]([type]) initialized multiple times!")
flags_1 |= INITIALIZED_1
return INITIALIZE_HINT_NORMAL

/mob/dview/Destroy(force = FALSE)
Expand Down
2 changes: 1 addition & 1 deletion code/datums/mutations/antenna.dm
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
icon_state = "walkietalkie"

/obj/item/implant/radio/antenna/Initialize(mapload)
..()
. = ..()
radio.name = "internal antenna"

/datum/mutation/human/antenna/on_acquiring(mob/living/carbon/human/owner)
Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/items/weaponry.dm
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ for further reading, please see: https://github.com/tgstation/tgstation/pull/301
user.gain_trauma(/datum/brain_trauma/magic/stalker, TRAUMA_RESILIENCE_MAGIC)

/obj/item/katana/cursed/Initialize()
..()
. = ..()
ADD_TRAIT(src, TRAIT_NODROP, CURSED_ITEM_TRAIT)

/obj/item/wirerod
Expand Down
2 changes: 1 addition & 1 deletion code/modules/cargo/supplypod.dm
Original file line number Diff line number Diff line change
Expand Up @@ -534,9 +534,9 @@
layer = PROJECTILE_HIT_THRESHHOLD_LAYER

/obj/effect/pod_landingzone_effect/Initialize(mapload, obj/structure/closet/supplypod/pod)
. = ..()
transform = matrix() * 1.5
animate(src, transform = matrix()*0.01, time = pod.landingDelay+pod.fallDuration)
..()

/obj/effect/pod_landingzone //This is the object that forceMoves the supplypod to it's location
name = "Landing Zone Indicator"
Expand Down
2 changes: 1 addition & 1 deletion code/modules/surgery/organs/tails.dm
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
var/spines = "None"

/obj/item/organ/tail/lizard/Initialize()
..()
. = ..()
color = "#"+ random_color()

/obj/item/organ/tail/lizard/Insert(mob/living/carbon/human/H, special = 0, drop_if_replaced = TRUE)
Expand Down

0 comments on commit 899a9e0

Please sign in to comment.