Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v: allow shared anon struct + fix shared struct field initialization with no default value #23448

Merged
merged 5 commits into from
Jan 14, 2025
Merged

v: allow shared anon struct + fix shared struct field initialization with no default value #23448

merged 5 commits into from
Jan 14, 2025

Conversation

felipensp
Copy link
Member

Fix #23440

@huly-for-github Huly for GitHub
Copy link

Connected to Huly®: V_0.6-21878

@felipensp felipensp marked this pull request as ready for review January 12, 2025 21:10
@felipensp
Copy link
Member Author

The CI failure looks unrelated to the PR. But introducted recently by ecdsa support.

@felipensp
Copy link
Member Author

The CI failure looks unrelated to the PR. But introducted recently by ecdsa support.

Memleak Fix #23450

@spytheman
Copy link
Member

If you rebase with: git pull --rebase origin master,
it will pickup your fix, and the CI should be fine now.

@felipensp felipensp force-pushed the fix_shared_struct_to_str branch from 63ea595 to f148725 Compare January 13, 2025 10:56
@felipensp felipensp changed the title v: allow shared anon struct + fix shared field initialization v: allow shared anon struct + fix shared struct field initialization with no default value Jan 13, 2025
spytheman
spytheman approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Thank you 🙇🏻‍♂️.

@spytheman spytheman merged commit 8f0242e into vlang:master Jan 14, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vfmt removing shared from before shared struct {...}
2 participants
@felipensp @spytheman