Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smtp: fix crash when reconnecting with encrypted=true #23290

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Dec 27, 2024

@JalonSolov
Copy link
Contributor

Should pick up the vsql workflow changes on your next commit.

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, that is interesting ... why do we have both .ssl and .encrypted fields 🤔 .
That seems like an invitation for subtle bugs, when they are not both set, unless it also allows for some kind of encryption, != ssl 🤔 .

@spytheman
Copy link
Member

Good work.

@JalonSolov
Copy link
Contributor

I wondered about having both ssl and encrypted... shouldn't they mean the same thing? At any rate, I didn't spend enough time examining the code or the specs to see if there was a valid reason I was missing.

@spytheman
Copy link
Member

I think the gcc job has stuck.
I am merging it as it is.

@spytheman spytheman marked this pull request as ready for review December 27, 2024 19:50
@spytheman spytheman merged commit 6025893 into vlang:master Dec 27, 2024
59 of 62 checks passed
@medvednikov
Copy link
Member

should definitely only have encrypted

@JalonSolov
Copy link
Contributor

Right now, it has all 3 of ssh, starttls, and encrypted. Seems like triple redundancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault when setting "encrypted" field to true during net.smtp client connection
4 participants