-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/sha512: move sha512 long message tests to separate repo #22208
Conversation
I'm glad I didn't mess things up too badly. Really appreciate the assistance. |
I am happy to help when I can.
|
What do you think of copying For me locally, the current full version, takes over 30 seconds to run without optimizations on, and over 10 seconds with -prod, while with just the first 2 test cases, it takes <1s without optimizations and ~6s with (most of the time is spend in the compilation): |
I have no problem with doing that. We should have at least 1 test in the reduced pbkdf2_test.v where the key_length is greater than the block size of the hash. That was what revealed the bug I ran in to. I can generate a test case with a 256 byte key_length but fewer rounds. Something like c = 16 shouldn't take too long. What do you think? |
Very well then. |
I have run out of time to do this right now but I will get to it tomorrow. |
In 56013a4, I've left 'test case 7', which has key_length > block_size for sha256 and sha224 afaik. The full version of it, is in https://github.com/vlang/slower_tests now.
(half of that time is compilation) |
As discussed in 22187, the long message tests have been moved to a separate repo. I have left the short message tests here since the test cases are easily accommodated in the test source file.
Even though the long message tests in sha256 and sha1 did not cause any compile time errors with MSVC, I can do the same organization that I did for sha512 and move the long message tests for sha256 and sha1 over to the slower_tests repo.