Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgen: fix auto str for fn struct member #21825

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

felipensp
Copy link
Member

Fix #21823

@felipensp felipensp marked this pull request as ready for review July 8, 2024 13:39
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

The CI failures are not related imho. c2v and vdoom had recent changes, that may be responsible for them.

func: implementation
}
println('${m}')
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but do add newline in the end of file

@@ -0,0 +1,3 @@
static string main__MyStruct_str(main__MyStruct it) { return indent_main__MyStruct_str(it, 0);}
static string main__Function_str() { return _SLIT("fn (int)");}
string _t1 = main__Function_str();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

@spytheman spytheman merged commit 494be20 into vlang:master Jul 9, 2024
73 of 76 checks passed
@thomas-mangin
Copy link
Contributor

Thank you @felipensp

@felipensp felipensp deleted the fix_auto_str_for_fn2 branch July 9, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C codegen for struct with function member has gcc generating warnings
4 participants