Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbg: fix scope command when breakpoint is on or-expr #21747

Merged
merged 2 commits into from
Jul 1, 2024
Merged

dbg: fix scope command when breakpoint is on or-expr #21747

merged 2 commits into from
Jul 1, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Jun 27, 2024 •
edited
Loading

Fix #21772

fn r() !bool {
	return error('fail')
}

fn main() {
	a := r() or {
		$dbg
		false
	}
}

@spytheman
Copy link
Member

A regression test would be also nice.

@felipensp felipensp marked this pull request as ready for review July 1, 2024 11:49
@spytheman spytheman force-pushed the fix_dbg_or_expr_scope_var branch from cb74a17 to 5f6dccc Compare July 1, 2024 12:39
@spytheman
Copy link
Member

(rebased over master, to fix an unrelated CI error)

@spytheman spytheman merged commit 4fc6c7e into vlang:master Jul 1, 2024
76 checks passed
raw-bin pushed a commit to raw-bin/v that referenced this pull request Jul 2, 2024
@felipensp @raw-bin
cgen: fix scope command when $dbg breakpoint is on or-expr (fix vla…
34139c7 
…ng#21772) (vlang#21747)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$dbg does not work everywhere
2 participants
@felipensp @spytheman