Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.pref: cleanup os from and to string functions #21396

Merged
merged 1 commit into from
May 1, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented May 1, 2024

Split up of #21395 to allow isolating bug.

@spytheman in regards to what I commented in the linked PR about using:

fn res_fn()  ! {
	return match {
		// ...
		else { error() }
		// vs
		else { return error() }
	}
}

I run the changes with just error instead of the return error in os_from_string with the results: https://github.com/ttytm/v/actions?query=branch%3Apriv%2Fpref%2Fos-cleanup+

@spytheman spytheman merged commit 7e3b277 into vlang:master May 1, 2024
53 checks passed
spytheman added a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants