v.pref: cleanup os from and to string functions #21396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up of #21395 to allow isolating bug.
@spytheman in regards to what I commented in the linked PR about using:
I run the changes with just
error
instead of thereturn error
inos_from_string
with the results: https://github.com/ttytm/v/actions?query=branch%3Apriv%2Fpref%2Fos-cleanup+