pref: cleanup Backend and CompilerType functions, make minor performance adjustments
#21389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JalonSolov
reviewed
Apr 30, 2024
| @@ -846,13 +846,12 @@ pub fn parse_args_and_show_errors(known_external_commands []string, args []strin | |||
| b := backend_from_string(sbackend) or { | |||
| eprintln_exit('Unknown V backend: ${sbackend}\nValid -backend choices are: c, go, interpret, js, js_node, js_browser, js_freestanding, native, wasm') | |||
| } | |||
| if b.is_js() { | |||
| res.output_cross_c = true | |||
| } | |||
| if b == .wasm { | |||
There was a problem hiding this comment.
Need a b.is_wasm() to align with the other backends.
There was a problem hiding this comment.
Okay checking, it's correct as it is. For the backends there only is .wasm. For the oses there is:
.wasm32,
.wasm32_emscripten,
.wasm32_wasi,
// Native wasm options:
.wasi,
.browser,
There was a problem hiding this comment.
There are several js output variations as well...
Note that `js` defaults to the `node` codegen backend but it's also possible to
pick another:
* `js_browser` - V outputs JS source code ready for the browser.
* `js_node` - V outputs JS source code to run with nodejs.
* `js_freestanding` - V outputs JS source code with no hard runtime dependency.
wasm is definitely set up different from the others, if it differentiates via os rather than backend.
spytheman
reviewed
Apr 30, 2024
Co-authored-by: Delyan Angelov <[email protected]>
spytheman
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does a cleanup and makes minor adjustments. E.g., sorting match arms for more relevant matches first, adding a
gccarm instead of using it only in the fallback.