cgen: fix chan generic code generation #19993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delta456
reviewed
Nov 25, 2023
| @@ -924,7 +924,12 @@ pub fn (t &Table) chan_cname(elem_type Type, is_mut bool) string { | |||
| } else if elem_type.is_ptr() { | |||
| suffix = '_ptr' | |||
| } | |||
| return 'chan_${elem_type_sym.cname}' + suffix | |||
| type_name := if elem_type_sym.cname.contains('[') { | |||
There was a problem hiding this comment.
We still support <T> generics so another condition should be added here.
There was a problem hiding this comment.
This is not a problem. Have you a test case?
spytheman
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19609
🤖[deprecated] Generated by Copilot at f391db2
Fix a bug in generating C names for generic channels with array types in
vlib/v/ast/table.vand add a test case invlib/v/tests/chan_generic_test.vto verify the fix.🤖[deprecated] Generated by Copilot at f391db2
vlib/v/tests/chan_generic_test.v(link)