Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

term.ui: fix in -prod mode (stop abusing ub) #19529

Merged
merged 4 commits into from
Oct 10, 2023
Merged

term.ui: fix in -prod mode (stop abusing ub) #19529

merged 4 commits into from
Oct 10, 2023

Conversation

Wertzui123
Copy link
Contributor

https://discord.com/channels/592103645835821068/592294828432424960/1160584458626404383

[...] it's coming from if !C.GetConsoleMode(stdin_handle, &ui.stdin_at_startup) {

https://discord.com/channels/592103645835821068/592294828432424960/1160589397259993271

[...] it's only with GCC/clang and doesn't have anything to do with -prod and I guess it's probably because you're passing a const and expect it to be modified. [...]

@spytheman spytheman merged commit a1c16a7 into vlang:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JalonSolov JalonSolov JalonSolov left review comments

@medvednikov medvednikov medvednikov left review comments

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wertzui123 @spytheman @medvednikov @JalonSolov