builtin: speed up string concatenation and repeat() method with vmemcpy
#18206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mcpy instead of `for` loop for copying data These changes almost do not speed up the program with the `-prod` flag, since modern С compilers can do such optimization on their own, but in normal mode, the performance gain is from 1.6 (concatenation) to 1.8 (repeat) times. Concatenation: Old (`for` loop): Time (mean): 3.699 s +- 0.071 s [User: 3.629 s, System: 0.069 s] Range (min ... max): 3.548 s ... 3.741 s 10 runs New (vmemcpy): Time (mean): 2.305 s +- 0.065 s [User: 2.263 s, System: 0.041 s] Range (min ... max): 2.172 s ... 2.355 s 10 runs `vmemcpy version` ran 1.60 +- 0.05 times faster than 'for loop version'
i582
changed the title
repeat() method with vme mcpyrepeat() method with vmemcpy
|
Maybe your PR covers #276 ? |
It seems not, it suggests optimizing several concatenations in a row in order to allocate memory only once |
l1mey112
pushed a commit
to l1mey112/v
that referenced
this pull request
Jun 7, 2023
…mcpy instead of `for` loop for copying data (vlang#18206) These changes almost do not speed up the program with the `-prod` flag, since modern С compilers can do such optimization on their own, but in normal mode, the performance gain is from 1.6 (concatenation) to 1.8 (repeat) times. Concatenation: Old (`for` loop): Time (mean): 3.699 s +- 0.071 s [User: 3.629 s, System: 0.069 s] Range (min ... max): 3.548 s ... 3.741 s 10 runs New (vmemcpy): Time (mean): 2.305 s +- 0.065 s [User: 2.263 s, System: 0.041 s] Range (min ... max): 2.172 s ... 2.355 s 10 runs `vmemcpy version` ran 1.60 +- 0.05 times faster than 'for loop version'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
forloop for copying dataThese changes almost do not speed up the program with the
-prodflag, since modern С compilers can do such optimization on their own, but in normal mode, the performance gain is from 1.6 (concatenation) to 1.8 (repeat) times.🤖 Generated by Copilot at 7ea5db3
Refactor the
stringmodule to use a faster and clearer memory copying function. This affectsvlib/builtin/string.vand its tests.🤖 Generated by Copilot at 7ea5db3
vmemcpycalls to improve performance and readability of string operations (link, link) invlib/builtin/string.v