checker: fix missing detection for return in lockexpr stmts (fix #2…

…3434) (#23435)

vlib/v/checker/return.v

@@ -359,6 +359,10 @@ fn has_top_return(stmts []ast.Stmt) bool {
 					if stmt.expr.method_name == 'compile_error' {
 						return true
 					}
+				} else if stmt.expr is ast.LockExpr {
+					if has_top_return(stmt.expr.stmts) {
+						return true
+					}
 				}
 			}
 			else {}

vlib/v/checker/tests/lockexpr_missing_return_err.out

@@ -0,0 +1,7 @@
+vlib/v/checker/tests/lockexpr_missing_return_err.vv:4:1: error: missing return at end of function `baz`
+    2 | }
+    3 | 
+    4 | fn baz(shared foo Foo) int {
+      | ~~~~~~~~~~~~~~~~~~~~~~~~~~
+    5 |     lock foo {
+    6 |     }

vlib/v/checker/tests/lockexpr_missing_return_err.vv

@@ -0,0 +1,18 @@
+struct Foo {
+}
+
+fn baz(shared foo Foo) int {
+	lock foo {
+	}
+}
+
+fn bar(shared foo Foo) int {
+	lock foo {
+		return 1
+	}
+}
+
+fn main() {
+	shared foo := Foo{}
+	bar(shared foo)
+}