Skip to content

Commit

Permalink
Merge pull request #262 from vizzuhq/add_data_frame
Browse files Browse the repository at this point in the history
Fixed: the deprecated `add_data_frame` functions are not affected by the default `MAX_ROWS`
  • Loading branch information
veghdev authored Aug 22, 2023
2 parents 2799336 + 25acac8 commit f1c1841
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions src/ipyvizzu/animation.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import abc
import json
from os import PathLike
import sys
from typing import List, Optional, Tuple, Type, Union
import warnings

Expand Down Expand Up @@ -378,7 +379,12 @@ def add_data_frame(
DeprecationWarning,
stacklevel=2,
)
self.add_df(data_frame, default_measure_value, default_dimension_value)
self.add_df(
data_frame,
default_measure_value,
default_dimension_value,
max_rows=sys.maxsize,
)

def add_df_index(
self,
Expand Down Expand Up @@ -447,7 +453,7 @@ def add_data_frame_index(
DeprecationWarning,
stacklevel=2,
)
self.add_df_index(data_frame, name)
self.add_df_index(data_frame, column_name=name, max_rows=sys.maxsize)

def add_np_array(
self,
Expand Down

0 comments on commit f1c1841

Please sign in to comment.