Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT Fix tooltip rebase bt5 #480

Closed
wants to merge 43 commits into from
Closed

DRAFT Fix tooltip rebase bt5 #480

wants to merge 43 commits into from

Conversation

milospp
Copy link
Contributor

@milospp milospp commented Dec 3, 2024

Thank you for submitting a pull request! Title this pull request with a brief description of what the pull request fixes/improves/changes. Please describe the pull request in detail using the template below.

VIVO GitHub issue: (please link to issue)

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this pull request do?

A brief description of what the intended result of the PR will be and/or what problem it solves.

What's new?

An in-depth description of the changes made by this PR. Technical details and possible side effects. Include screenshots if appropriate.

Example:

  • Changes x feature to such that y
  • Added x
  • Removed y

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the pull request does what is intended.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Example:

  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository?
  • Could this change impact execution of existing code?
  • Large pull requests should be avoided. If this PR is large (more than 1,000 lines of codes), please provide short explanation why your contribution can't be decoupled in smaller PRs.

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

Reviewers' expertise

Please add any new expertise in the list which might be needed for reviewing your PR or remove any of the listed if it is not needed.

Candidates for reviewing this PR should have some of the following expertises:

  1. Java
  2. HTML, CSS, JavaScript
  3. FreeMarker
  4. SPARQL
  5. Ontologies
  6. Docker
  7. Natural language knowledge
    1. English
    2. German
    3. Spanish
    4. French
    5. Portuguese
    6. Russian
    7. Serbian

Reviewers' report template

Please update the following template which should be used by reviewers.

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

litvinovg and others added 30 commits May 31, 2024 13:37
@litvinovg
Added Boostrap 5 webjar dependency
9605af0
@milospp
rebase to bootstrap5 pr
ef59d70
@milospp
Removed Qtip libraries and modifies style for tooltip
fed943f
@milospp
Fixed position of download popup
f080db9
@milospp
Fixed popper for Vitro, Nemo and Tenderfoot themes
82ee4ec
@milospp
Fixed tooltip design and nemo theme search results page
86760b1
@milospp
Removed !important tags
7e2e4ad
@milospp
Fixed opacity difference
9256f0a
@milospp
Created tooltip css for everytheme to reduce reduntant code
0376451
@milospp
Renamed vivoToolip to vitroTooltip
4f16acc
@milospp
Refactored code
890d122
@litvinovg @milospp
Added permissions required to upload images
564862e
@litvinovg @milospp
Avoid duplicate statements in CONSTRUCT query to improve perfomance
8275e63
@litvinovg @milospp
refact: removed not used method parameter
4d7a725
@litvinovg @milospp
refact: replaced SparqlGraph.sparqlNodeDelete with sparqlNodeDelete
4aabf69
@litvinovg @milospp
Fixed SparqlSelectQueryResultsChecker
1ffc9a2
@chenejac @ivanmrsulja @milospp
Disallow forms (with CAPTCHA) to bots (vivo-project#438)
c7f71b4 
* Disallow forms (with CAPTCHA) to bots

* Update webapp/src/main/webapp/robots.txt

Co-authored-by: Ivan R. Mršulja <[email protected]>

---------

Co-authored-by: Ivan R. Mršulja <[email protected]>
@litvinovg @milospp
fix: DataAutoCompleteController
7b5490a 
check authorization in DataAutoCompleteController
@litvinovg @milospp
IndividualListController, AutocompleteController
8aef4ef
@litvinovg @milospp
refactored SearchFiltering methods to get rid of VitroRequest paramet…
1134755 
…er in public methods
@litvinovg @milospp
Apply search filters in DefaultDataPropertyFormGenerator
143da5f
@litvinovg @milospp
removed unused import
4765c47
@litvinovg @milospp
reverted changes that break language filtering
d499317
@hauschke @milospp
Translated SPARQL interface to DE
69d2636
@hauschke @chenejac @milospp
Update home/src/main/resources/rdf/i18n/de_DE/interface-i18n/firsttim…
3789095 
…e/vitro_UiLabel.ttl

Co-authored-by: Dragan Ivanovic <[email protected]>
@hauschke @chenejac @milospp
Update home/src/main/resources/rdf/i18n/de_DE/interface-i18n/firsttim…
b54b9fa 
…e/vitro_UiLabel.ttl

Co-authored-by: Dragan Ivanovic <[email protected]>
@hauschke @chenejac @milospp
Update home/src/main/resources/rdf/i18n/de_DE/interface-i18n/firsttim…
2bb32fc 
…e/vitro_UiLabel.ttl

Co-authored-by: Dragan Ivanovic <[email protected]>
@litvinovg @milospp
Avoid lock on graph uri update in rdfServiceSparql
08db9f4
@litvinovg @milospp
delete duplicate variable initialization
8c87fb1
@litvinovg @milospp
fix identation
3fdb20d
litvinovg and others added 13 commits December 3, 2024 10:14
@litvinovg @milospp
refact: extracted method to update graph URIs in RDFServiceImpl
4c506ba
@litvinovg @milospp
style: fixed layout, removed files from checkstyle suppressions
b025626
@litvinovg @milospp
fix: reset rebuildGraphUriCache flag at start of graphUriRebuild to a…
9b45c07 
…void missed graph updates
@chenejac @milospp
[maven-scm-plugin] prepare release vitro-1.15.0
76df49e
@chenejac @milospp
[maven-scm-plugin] prepare release vitro-1.15.1-SNAPSHOT
abc942c
@litvinovg @milospp
Enable tinyMCE for fixed html pages
678d6a0
@litvinovg @milospp
fixes
2c98787
@litvinovg @milospp
VIVO-4000 Removed text from csv export template. Added date and site …
fceb614 
…name to export csv file.
@litvinovg @milospp
fixes for file name
f761306
@litvinovg @milospp
fixed autocompletion cache
014c4b3
@litvinovg @milospp
Support Unicode characters in reconciliation API (vivo-project#476)
196d6c3 
* use PrintWriter in JSONReconcile servlet

* removed not used import
@milospp
Adding bootstrap-5.3.2
5de0542
@milospp
Added padding in tooltip
5639f5c
@milospp milospp closed this Dec 12, 2024
@milospp milospp deleted the fix-tooltip-rebase-bt5 branch December 12, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milospp @litvinovg @chenejac @hauschke