Add Jquery and Jquery UI webjars #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litvinovg
force-pushed
the
jquery-webjars
branch
from
9aab495 to
12de380
Compare
chenejac
requested changes
May 7, 2024
There was a problem hiding this comment.
General comment
@litvinovg thanks a lot for this PR.
Testing
I have run building of VIVO and webjars directory inside webapps/target directory has been created.
Code reviewing
I have posted one comment regarding group id for datatables.net artifact. I am also wondering whether we need all those dependencies extracted into webjars directory, or we can use existing js, and css directories?
chenejac
approved these changes
May 9, 2024
|
.
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Dragan Ivanovic ***@***.***>
Sent: Thursday, May 9, 2024 1:12:19 AM
To: vivo-project/Vitro ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [vivo-project/Vitro] Add Jquery and Jquery UI webjars (PR #464)
@chenejac approved this pull request.
________________________________
In webapp/pom.xml<#464 (comment)>:
@@ -38,6 +121,26 @@
</build>
<dependencies>
+ <dependency>
+ <groupId>org.webjars.npm</groupId>
+ <artifactId>jquery-migrate</artifactId>
+ <version>3.4.1</version>
+ </dependency>
+ <dependency>
+ <groupId>org.mvnpm</groupId>
But it is available at https://mvnrepository.com/artifact/org.webjars.npm/datatables.net? Probably I am missing something
________________________________
In webapp/pom.xml<#464 (comment)>:
@@ -38,6 +121,26 @@
</build>
<dependencies>
+ <dependency>
+ <groupId>org.webjars.npm</groupId>
+ <artifactId>jquery-migrate</artifactId>
+ <version>3.4.1</version>
+ </dependency>
+ <dependency>
+ <groupId>org.mvnpm</groupId>
let's keep group id which is set at the moment
—
Reply to this email directly, view it on GitHub<#464 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAUNTVZFIHXLCRW5AAXM22LZBMOVHAVCNFSM6AAAAABGWPYBYKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBSHE4TCNZYHA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
wwelling
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Added webjars with latest jquery and jquery ui versions
Added datatables dependency used by Map of Science
https://mvnrepository.com/artifact/org.mvnpm/datatables.net/2.0.5
Added jquery migrate dependency
https://mvnrepository.com/artifact/org.webjars.npm/jquery-migrate/3.4.1
All dependencies are licensed under the MIT license.
How should this be tested?
Build Vitro and VIVO
Interested parties
@gneissone
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed