-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute based access control implementation #3887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment here, which is more likely that explanation is needed than fixing.
api/src/main/java/org/vivoweb/webapp/controller/freemarker/CreateAndLinkResourceController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg great work. Let's wait for one more review, especially review of the ABAC ontology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I have left a few comments discussing minor variable naming changes
...lib/vitro/webapp/edit/n3editing/configuration/generators/ManageLabelsForPersonGenerator.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/vivoweb/webapp/controller/freemarker/CreateAndLinkResourceController.java
Outdated
Show resolved
Hide resolved
…es to add/edit/drop
Tested migration of existing custom roles and related permissions. Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg VIVO PR is completed from my point of view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine from my point of view. Good job! Just fix this compilation error that popped up 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@litvinovg well done
VIVO GitHub issue
Vitro PR
What does this pull request do?
This pull request is a VIVO part of new authorization mechanism that provides flexible way to configure access rules and check access requests.
What's new?
This pull requests contains:
You can find more information in Vitro PR.
How should this be tested?
There are 2 ways to test it:
Apply changes in PR for Vitro and for VIVO, build and deploy your VIVO.
Check if access works the same as it worked before for object properties, data properties, faux object properties and faux data properties.
Check if access works the same as it worked in ARM. Standard VIVO checks are required to test this PR.
If you want to try new policies, try edit policies in firsttime directory, reload VIVO and see results.
Apply changes in PR for Vitro and for VIVO
Make sure to retain ARM entity permission configurations in auth/firsttime folder to retain auth graph state for conversion of ARM permissions into policy datasets.
Build and deploy your VIVO.
Check if access works the same as it worked in ARM.
If you want to try new policies, try edit policies in firsttime directory, reload VIVO and see results.
Additional notes
Interested parties
@chenejac @vivo-project/vivo-committers