Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Doc counter #133

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Doc counter #133

wants to merge 3 commits into from

Conversation

spring-raining
Copy link
Member

@spring-raining spring-raining commented Sep 8, 2024

#129

  • Fix cases where both the chapter and part page counters are set
  • Don't increment vs-counter-doc for ToC/cover documents
  • Add variables to override the initial counter value at the document root

  • 1つのドキュメントに partchapter 両方のクラスが指定されていたときに vs-counter-part のカウンターがインクリメントされない問題を修正します
  • ドキュメント内に [role='doc-toc'][role='doc-cover'] が含まれていたときに vs-counter-doc をインクリメントしないようにします。これにより、目次ページやカバーページが章としてカウントされないように修正します
  • CSSカウンターの初期値をドキュメントルートで上書きするCSS変数を追加しました

@spring-raining spring-raining self-assigned this Sep 8, 2024
@spring-raining spring-raining marked this pull request as draft September 8, 2024 08:49
@spring-raining spring-raining marked this pull request as ready for review September 8, 2024 09:42
@MurakamiShinyu
Copy link
Member

@spring-raining これらのカウンターを使ったテストサンプルはないですか?

Copy link
Member

@MurakamiShinyu MurakamiShinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

複数文書でvs-counter-chapter、vs-counter-docなどを使う簡単な例を作りながら試して、これらのカウンターが機能することを確認しました。vs-counter-sectionsと組み合わせての使い方などは難しい感じですが、まずはこれでapproveします。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants