Test with outputs #5
Conversation
| import java.util.concurrent.TimeUnit | ||
|
|
||
| data class TestQuery(val functions:List<Func>, val names:List<String> , val query:Query){ | ||
| val map: Map<String, Func> |
There was a problem hiding this comment.
What is this variable naming 🤣
| import java.io.IOException | ||
| import java.util.concurrent.TimeUnit | ||
|
|
||
| data class TestQuery(val functions:List<Func>, val names:List<String> , val query:Query){ |
There was a problem hiding this comment.
There aren't any examples of this constructor nor runTest being called, so I'm not totally sure if I have the right idea, but it seems to me like the values declared in files in examples/ get passed to TestQuery. In that case, it would make a lot of sense to make some interface I containing the list of functions, names, and query, so TestQuery can take an I as input, and all the stuff in each examples/ file can be wrapped in an object which implements I.
The syntax would be something like object ListQuery implements I { ... }
There was a problem hiding this comment.
Line 12 of ListQuery was supposed to be a testQuery instance with the functions, strings, et al in it(forgot to add&commit), can either go add or replace w/ this. This ^^ sounds like a more organized idea - I think the thought process was that TQ would only take in fields that were already universal & ready to go, and every example file would have a TQ that main had access to and called rT on.
There was a problem hiding this comment.
Either is fine I'd rather get a MVP up so we're able to run tests and investigate the remaining questions
no clue if this is idiomatic, down to chuck it or reproduce 400 of these.