Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #9 (negate_sequence bug) #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josmithua
Copy link

Please review my fix for issue #9.

I use the stripped version of the word (lowered and stripped of delims) to see if it equals "not", "cannot", "no", or if it ends with "n't". If any of these are true, then negation is negated.

This fixes both issues of:

  1. negation being changed when seeing words containing ["no", "not", "n't"] (e.g. "know")
  2. negation not being changed when seeing things that are uppercase that should trigger negation being changed but don't. (i.e., capital "DON'T")

I added the word "cannot" because if I checked if stripped.endswith("not") then that would match words like "knot" and "whatnot". I'm assuming negation is wanted when observing the word "cannot". If this is a wrong assumption please let me know.

Cheers,
@sm1th

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants