Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add missing onAdd and onAdded calls in File module and implement set_image_meta #1391

Merged
merged 6 commits into from
Feb 3, 2025
Merged

feat: Add missing onAdd and onAdded calls in File module and implement set_image_meta #1391

merged 6 commits into from
Feb 3, 2025

Conversation

sveneberth
Copy link
Member

@sveneberth sveneberth commented Jan 25, 2025 •
edited
Loading

set_image_meta fills the width and height bones of a FileSkel with the image dimensions.

@sveneberth
feat: Add missing onAdd and onAdded called in File and implement …
f33e6ba 
…`set_image_meta`

`set_image_meta` fills the `width` and `height` bones of a `FileSkel`
with the image dimensions.
@sveneberth sveneberth added feature New feature or request Priority: Medium This issue may be useful, and needs some attention. labels Jan 25, 2025
@sveneberth sveneberth requested review from phorward and akelch January 25, 2025 03:12
@sveneberth sveneberth changed the title feat: Add missing onAdd and onAdded called in File and implement … feat: Add missing onAdd and onAdded calls in File module and implement set_image_meta Jan 25, 2025
@phorward phorward added the viur-meeting Issues to discuss in the next ViUR meeting label Jan 31, 2025
@phorward phorward merged commit 3887e44 into viur-framework:main Feb 3, 2025
3 checks passed
@sveneberth sveneberth deleted the feature/file_hooks_and_meta branch February 4, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward approved these changes

@ArneGudermann ArneGudermann ArneGudermann approved these changes

@akelch akelch Awaiting requested review from akelch

Assignees
No one assigned
Labels
feature New feature or request Priority: Medium This issue may be useful, and needs some attention. viur-meeting Issues to discuss in the next ViUR meeting
Projects
Documentation
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sveneberth @phorward @ArneGudermann