Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rebase contracts and support ERC721 #19

Merged
merged 16 commits into from
Oct 26, 2023
Merged

Conversation

vittominacori
Copy link
Owner

This PR adds support for ERC721 tokens.

Recover contracts have been defined at a low level.
The recover contracts define internal methods that can be used in derived contracts.

The recover[ERC20|ERC721] now requires also the receiver address.

Improve test and documentation.

Should fix #7

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #19 (fa32637) into master (bfad07f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         5    +2     
  Lines            5        17   +12     
  Branches         1         4    +3     
=========================================
+ Hits             5        17   +12     
Files Coverage Δ
contracts/ERC20Recover.sol 100.00% <100.00%> (ø)
contracts/ERC721Recover.sol 100.00% <100.00%> (ø)
contracts/TokenRecover.sol 100.00% <100.00%> (ø)
contracts/recover/RecoverERC20.sol 100.00% <100.00%> (ø)
contracts/recover/RecoverERC721.sol 100.00% <100.00%> (ø)

@vittominacori vittominacori self-assigned this Oct 26, 2023
@vittominacori vittominacori merged commit 53fd6d6 into master Oct 26, 2023
7 checks passed
@vittominacori vittominacori deleted the feat/support-nft branch October 26, 2023 09:46
vittominacori added a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support other token standards
2 participants