Avoid to get an extra move when puzzle is incomplete #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example(after Ke3 next move is reported as ambiguous, but Ke3 is in the pgn): 29. Rg1 Ne2+ 30. Kd2 Nxg1 31. Ke3 0-1 We take into account the last move only if it's the player turn. Than we have: 29. Rg1 Ne2+ 30. Kd2 Nxg1 0-1
|
Hi @bend86 thanks for the PR, I think it make sense but to be sure that we are not failing to see some edge case, can you post the pgn of your example? or other examples |
|
@karol-brejna-i Now that you were deep into code, what do you think of this PR? |
|
I'll fix my previous PR (which will deepen my understanding of the code), and take a look at this afterward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example(after Ke3 next move is reported as ambiguous, but Ke3 is in the pgn):
29. Rg1 Ne2+ 30. Kd2 Nxg1 31. Ke3 0-1
We take into account the last move only if it's the player turn. Than we have:
29. Rg1 Ne2+ 30. Kd2 Nxg1 0-1