Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly render ansi diff #3788

Closed
wants to merge 4 commits into from
Closed

fix: correctly render ansi diff #3788

wants to merge 4 commits into from

Conversation

so1ve
Copy link
Contributor

@so1ve so1ve commented Jul 20, 2023

close #3675

@stackblitz
Copy link

stackblitz bot commented Jul 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for fastidious-cascaron-4ded94 failed.

Name Link
🔨 Latest commit 9f3fee8
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/64bfa7b1545eb10008119d6d

@so1ve
Copy link
Contributor Author

so1ve commented Jul 20, 2023

Force pushed for a wrong refactor 😅

@antfu
Copy link
Member

antfu commented Jul 20, 2023

The lock changes do not seem to needed?

@so1ve
Copy link
Contributor Author

so1ve commented Jul 20, 2023

The lock changes do not seem to needed?

I'm not sure about it. If I don't push it, the ci will fail.

@sheremet-va
Copy link
Member

CI still fails without it it seems. Please, revert all package-lock changes you made

@so1ve
Copy link
Contributor Author

so1ve commented Jul 25, 2023

@sheremet-va Thanks! I've just reverted this change.

@so1ve so1ve closed this Jul 25, 2023
@so1ve
Copy link
Contributor Author

so1ve commented Jul 25, 2023

I'll create a new branch to avoid unnecessary changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It looks like this change may have caused the output in @vitest/ui to print ANSI escape codes.
3 participants