-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Filtering UI down to Individual test blocks #3505
Conversation
Signed-off-by: GurkiranSingh <[email protected]>
Run & review this pull request in StackBlitz Codeflow. |
run |
/> | ||
<div> | ||
<IconButton | ||
v-if="testIndex !== null || isDescribeBlock !== null || selectedTest !== null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create a computed property that holds this to avoid duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Signed-off-by: GurkiranSingh <[email protected]>
Co-authored-by: Anjorin Damilare <[email protected]>
Signed-off-by: GurkiranSingh <[email protected]>
@userquin take a look at this again. |
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
Signed-off-by: GurkiranSingh <[email protected]>
…e workspace module fetch logic as per Vladimir suggestions Signed-off-by: GurkiranSingh <[email protected]>
Signed-off-by: GurkiranSingh <[email protected]>
Signed-off-by: GurkiranSingh <[email protected]>
Signed-off-by: GurkiranSingh <[email protected]>
This is implemented in #5948 |
Resolves: #3109
I have considered two ways to add this functionality:
There is also Codemirror add-ons for code folding which can be useful for this feature, but I haven't taken a deep look into it. https://codemirror.net/docs/ref/#language.foldCode
Video:
https://www.loom.com/share/9fdbf88ef5114b2fa76e45b119b31e61
Disclaimer: I am coming from React background, so I am learning Vue on the go, please let me know if I am missing best practices specific to Vue
Also, when I was trying to make commit, I am facing this eslint error, not sure why that occurred, so I have commited the files with
-n
flag.