Tabletbalancer docs #1804
Tabletbalancer docs #1804
Conversation
Signed-off-by: Michael Demmer <[email protected]>
Signed-off-by: Michael Demmer <[email protected]>
demmer
force-pushed
the
tabletbalancer-docs
branch
from
30ebbc3
to
18d95df
Compare
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
LGTM
The only question I have is whether this should be marked as experimental. That gives us the freedom the change flags etc. if we need to.
@demmer @rohit-nayak-ps @systay WDYT?
| @@ -0,0 +1,90 @@ | |||
| --- | |||
| title: VTGate Tablet Balancer | |||
| aliases: ['/docs/user-guides/tablet-balancer/','/docs/reference/tablet-balancer/'] | |||
There was a problem hiding this comment.
Do we really need aliases for net-new docs?
@frouioui do you know?
There was a problem hiding this comment.
FWIW This was totally copy-pasted on my end.
There was a problem hiding this comment.
Then this line should be deleted.
Signed-off-by: Michael Demmer <[email protected]>
demmer
force-pushed
the
tabletbalancer-docs
branch
from
1c7212e
to
9d6e1e3
Compare
| @@ -45,6 +45,9 @@ vtgate \ | |||
| --allow-kill-statement Allows the execution of kill statement | |||
| --allowed_tablet_types strings Specifies the tablet types this vtgate is allowed to route queries to. Should be provided as a comma-separated set of tablet types. | |||
| --alsologtostderr log to standard error as well as files | |||
| --balancer-enabled Whether to enable the tablet balancer to evenly spread query load | |||
There was a problem hiding this comment.
Minor change to the flag name in the feature PR. This should now be --enable-balancer Enable the tablet balancer to evenly spread query load for a given tablet type and moved down to be above --enable-partial-keyspace-migration
There was a problem hiding this comment.
I can approve and merge once this is fixed.
|
Done. Thanks!
…On Thu, Aug 29, 2024 at 8:48 AM Deepthi Sigireddi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In content/en/docs/21.0/reference/programs/vtgate/_index.md
<#1804 (comment)>:
> @@ -45,6 +45,9 @@ vtgate \
--allow-kill-statement Allows the execution of kill statement
--allowed_tablet_types strings Specifies the tablet types this vtgate is allowed to route queries to. Should be provided as a comma-separated set of tablet types.
--alsologtostderr log to standard error as well as files
+ --balancer-enabled Whether to enable the tablet balancer to evenly spread query load
I can approve and merge once this is fixed.
—
Reply to this email directly, view it on GitHub
<#1804 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZHXWDQD4VSS73CLKVFDLDZT47EZAVCNFSM6AAAAABL3JLPEOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRZGI4DCOJYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: Michael Demmer <[email protected]>
demmer
force-pushed
the
tabletbalancer-docs
branch
from
dc07f50
to
b5d0596
Compare
Signed-off-by: Michael Demmer <[email protected]>
Add website command line and feature doc for vitessio/vitess#16351