-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/vt/vtgate: add mirror query stats to vtgate /debug/querylogz #17698
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Max Englander <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17698 +/- ##
==========================================
+ Coverage 67.77% 67.80% +0.02%
==========================================
Files 1587 1587
Lines 255798 255803 +5
==========================================
+ Hits 173379 173445 +66
+ Misses 82419 82358 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
<th>Execute Time</th> | ||
<th>Mirror Source Execute Time</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Execute Time
and Mirror Source Execute Time
same or different? Ideally a Mirror execution should not impact the query execution time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are measured in different places. Execute Time
is measured here:
vitess/go/vt/vtgate/executor.go
Line 383 in 0bf4276
logStats.ExecuteTime = time.Since(execStart) |
Mirror Source Execute Time
is measure here:
vitess/go/vt/vtgate/engine/mirror.go
Line 107 in 0bf4276
sourceExecTime = time.Since(sourceStartTime) |
so Mirror Source Execute Time
should include but may be slightly less than Execute Time
. The reason we have Mirror Source Execute Time
is to have an apples-to-apples way to compare the performance of mirroring.
Description
Expose mirror query stats in VTGate
/debug/querylogz
output.Related Issue(s)
Closes #17697.
Checklist
was added oris not requiredDeployment Notes