Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to know if DemotePrimary is blocked and send it in the health stream #17289

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

test: fix data race

a7cbc4a
Select commit
Loading
Failed to load commit list.
Open

Add a way to know if DemotePrimary is blocked and send it in the health stream #17289

test: fix data race
a7cbc4a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 22, 2024 in 0s

67.62% (+0.21%) compared to 8648264

View this Pull Request on Codecov

67.62% (+0.21%) compared to 8648264

Details

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.62%. Comparing base (8648264) to head (a7cbc4a).
Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/tabletserver.go 0.00% 5 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_replication.go 87.50% 2 Missing ⚠️
go/vt/vttablet/tabletservermock/controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17289      +/-   ##
==========================================
+ Coverage   67.40%   67.62%   +0.21%     
==========================================
  Files        1574     1583       +9     
  Lines      253205   254067     +862     
==========================================
+ Hits       170676   171807    +1131     
+ Misses      82529    82260     -269

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov