refac: Refactor Server.GetWorkflows()
#17092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noble Mittal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17092 +/- ##
==========================================
+ Coverage 67.33% 67.44% +0.11%
==========================================
Files 1569 1575 +6
Lines 252506 253252 +746
==========================================
+ Hits 170021 170809 +788
+ Misses 82485 82443 -42 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
beingnoble03
added
Type: Internal Cleanup
Component: VReplication
and removed
NeedsDescriptionUpdate
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
|
Can you give the test coverage before and after? |
|
Here's the coverage on main: and, here's the coverage on this branch: I used this cmd to generate the coverage report because go test ./go/vt/vttablet/tabletmanager ./go/vt/vtctl/workflow -coverpkg=vitess.io/vitess/go/vt/vtctl/workflow... -coverprofile=c.out |
Signed-off-by: Noble Mittal <[email protected]>
5 tasks
rohit-nayak-ps
approved these changes
Nov 18, 2024
deepthi
reviewed
Nov 25, 2024
| limitations under the License. | ||
| */ | ||
|
|
||
| package workflow |
There was a problem hiding this comment.
We have not done this in the past, but can you please write a top-level comment for what this file contains?
@rohit-nayak-ps you might need to help with that.
There was a problem hiding this comment.
Done. Please have a look.
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
mattlord
approved these changes
Dec 5, 2024
go/vt/vtctl/workflow/server.go
Outdated
| readReq := &tabletmanagerdatapb.ReadVReplicationWorkflowsRequest{} | ||
| if req.Workflow != "" { | ||
| readReq.IncludeWorkflows = []string{req.Workflow} | ||
| w := &workflow{ |
There was a problem hiding this comment.
Nit, but IMO a better name for this struct/type would be workflowReader or workflowFetcher. The term workflow[s] is already so overloaded today in the code.
| fetchLogsWG.Wait() | ||
| } | ||
|
|
||
| return maps.Values(workflowsMap), nil |
There was a problem hiding this comment.
It might be worth sorting the slice here by keyspace/workflowName. Can be done later.
Signed-off-by: Noble Mittal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetWorkflows()monolithic function into utility functions inworkflows.gofetchCopyStatesByShardStream,WorkflowStatus,getWorkflowCopyStates)Related Issue(s)
Checklist
Deployment Notes