-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomic Transactions correctness with PRS, ERS and MySQL & Vttablet Restarts #16553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…ed atomic Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
…the same column with extra information Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
… ers and mysql restarts secure Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
requested review from
frouioui,
rohit-nayak-ps,
deepthi,
mattlord,
harshit-gangal,
systay,
shlomi-noach and
timvaillancourt
as code owners
August 7, 2024 12:52
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Aug 7, 2024
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
removed
the
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
label
Aug 14, 2024
26 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good.
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
harshit-gangal
approved these changes
Aug 20, 2024
systay
reviewed
Aug 21, 2024
systay
reviewed
Aug 21, 2024
systay
reviewed
Aug 21, 2024
systay
reviewed
Aug 21, 2024
systay
reviewed
Aug 21, 2024
systay
approved these changes
Aug 21, 2024
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the code changes required to ensure that atomic transactions don't break their atomic guarantee in the face of disruptions like
PlannedReparentShard
,EmergencyReparentShard
, and MySQL and Vttablet restarts.A lot of the logic on how we redo the prepared transactions had to be reworked. This PR also adds the design docs for these changes so that they can referenced in the future too.
The testing strategy for ensuring these changes work as intended is 2-fold -
This PR also adds a new design doc explaining all the steps that are involved in guaranteeing that atomic transactions work well with each of the many disruptions
Related Issue(s)
Checklist
Deployment Notes