-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-19.0] go/vt/wrangler: pass reparent options structs (#15251) #15286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Layher <[email protected]>
vitess-bot
bot
added
Component: Cluster management
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
labels
Feb 19, 2024
vitess-bot
bot
requested review from
mattlord,
rohit-nayak-ps and
ajm188
as code owners
February 19, 2024 15:48
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
frouioui
approved these changes
Feb 19, 2024
mdlayher
approved these changes
Feb 19, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-19.0 #15286 +/- ##
================================================
+ Coverage 67.30% 67.32% +0.02%
================================================
Files 1558 1558
Lines 192095 192094 -1
================================================
+ Hits 129280 129332 +52
+ Misses 62815 62762 -53 ☔ View full report in Codecov by Sentry. |
dbussink
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport
This is a backport
Component: Cluster management
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #15251